-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show message if no other users with access are found #18701
Show message if no other users with access are found #18701
Conversation
Fixes #18632 Show a small subtitle if no other users with access are found. Signed-off-by: Roeland Jago Douma <[email protected]>
Hmm. |
Yeah the title jump is not ideal. But good enough for a quick fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
We can't do that. The toggle triggers a request to the backend. And since this can be very costly. We don't want to do it on all openings of the sidebar. |
Ok, then different proposal:
|
I find that very user friendly and self-documenting |
@jancborchardt fine by me. Please fill an issue. And we'll see if we can tackle it for 18. Or if it has to wait for 18.0.1 because of time constraints. |
Fixes #18632
Show a small subtitle if no other users with access are found.
In action: